Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement array_replace #4191

Merged
merged 2 commits into from
Aug 23, 2024
Merged

implement array_replace #4191

merged 2 commits into from
Aug 23, 2024

Conversation

aznszn
Copy link
Contributor

@aznszn aznszn commented Aug 22, 2024 •
edited
Loading

implemented array_replace function for postgres under #4153

@aznszn aznszn force-pushed the add_function_array_replace branch 2 times, most recently from ca32d8f to fca4212 Compare August 22, 2024 11:08
@weiznich weiznich requested a review from a team August 22, 2024 18:43
guissalustiano
guissalustiano approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@guissalustiano guissalustiano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for open the PR!

The changes look good for me, it has a well done test coverage too!

@aznszn
Copy link
Contributor Author

aznszn commented Aug 23, 2024

@guissalustiano thanks for reviewing!

this was my first open source pr so its nice to know it was all good

@weiznich weiznich mentioned this pull request Aug 23, 2024
Open
@weiznich
Copy link
Member

Thanks 👍

@weiznich weiznich added this pull request to the merge queue Aug 23, 2024
Merged via the queue into diesel-rs:master with commit f48c643 Aug 23, 2024
48 checks passed
@aznszn aznszn deleted the add_function_array_replace branch September 4, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guissalustiano guissalustiano guissalustiano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aznszn @weiznich @guissalustiano