Implement array_prepend and array_remove
#4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwinlzs
commented
Aug 20, 2024
edwinlzs
commented
Aug 20, 2024
|
I'm still new at contributing to the open source space, do let me know if there's anything that could be done better (e.g. if I should split implementations into 2 separate PRs instead of one) |
guissalustiano
approved these changes
Aug 20, 2024
|
@guissalustiano Thanks for reviewing this PR! I've added a commit with fixes for the issues you highlighted :) |
|
Thanks for contributing 👍 I've rebased this PR to resolve merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing
array_prependandarray_removefunctions for Postgres under #4153using specs https://www.postgresql.org/docs/current/functions-array.html