fix: tag value handling #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2024
Merged
diegomura
reviewed
Sep 22, 2024
src/markers/utils.js
Outdated
Comment on lines
57
to
63
| export const readInt32BE = (array, offset) => { | ||
| return readUInt32BE(array, offset) | 0; | ||
| }; | ||
|
|
||
| export const readInt32LE = (array, offset) => { | ||
| return readUInt32LE(array, offset) | 0; | ||
| }; |
There was a problem hiding this comment.
Why are these needed?
Also please add a new line at the end of the file :)
There was a problem hiding this comment.
These are for handling Case 9 & 10. Here's excerpt from EXIF standard:
9 = SLONG A 32-bit (4-byte) signed integer (2's complement notation).
10 = SRATIONAL Two SLONGs. The first SLONG is the numerator and the second SLONG is the
denominator.
Hence I added these methods to read signed ints, as existing methods only read unsigned numbers.
Friendseeker
force-pushed
the
signed-int-handling
branch
from
c77b7bd to
bbaef15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
_getTagValuehas following problemsThis PR fixes the above 3 problems, so
_getTagValueis fully in sync with EXIF spec.