Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using zotero-plugin release script instead of release-it #303

Open
wants to merge 1 commit into
base: zotero7
Choose a base branch
from

Conversation

diegodlh
Copy link
Owner

As mentioned in #296 (comment), I think it may be better to use zotero-plugin release script instead of release-it.

On the one hand, I think we haven't managed yet to maintain the special "release"/"update" release (which keeps the update.json and update-beta.json manifests) with the release-it approach. As far as I could understand, we replace all assets each time, which would mean losing the update.json manifest when a new beta release is published.

On the other hand, considering that we are using much of zotero-plugin-template features for the development of our plugin, I think it would be simpler to use their release approach too. But open to reconsideration, of course.

This pull request supposedly makes the changes needed to use zotero-plugin release script instead of release-it. It also updates the README according to comments in the discussion linked to above.

If we do merge this, we may want to remove the "update" release created before: https://github.com/diegodlh/zotero-cita/releases/tag/update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant