Fix the fix

dickwolff · Jan 19, 2025 · 33fc9ad · 33fc9ad
1 parent 9d5b38f
commit 33fc9ad
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/converters/revolutConverter.ts b/src/converters/revolutConverter.ts
@@ -176,7 +176,7 @@ export class RevolutConverter extends AbstractConverter {
             try {
                 security = await this.securityService.getSecurity(
                     null,
-                    record.ticker,
+                    record.ticker ?? `${record.symbol}-${record.currency}`,
                     null,
                     record.currency,
                     this.progress);
@@ -188,19 +188,19 @@ export class RevolutConverter extends AbstractConverter {
 
             // Log whenever there was no match found.
             if (!security) {
-                this.progress.log(`[i] No result found for ${record.type} action for ${record.ticker} with currency ${record.currency}! Please add this manually..\n`);
+                this.progress.log(`[i] No result found for ${record.type} action for ${record.ticker ?? record.symbol} with currency ${record.currency}! Please add this manually..\n`);
                 bar1.increment();
                 continue;
             }
 
             let quantity, unitPrice;
 
             if (record.type === "dividend") {
-                quantity = 1;
-                unitPrice = Math.abs(record.totalAmount);
+                quantity = record.quantity ?? 1;
+                unitPrice = Math.abs(record.totalAmount ?? 1);
             } else {
                 quantity = record.quantity;
-                unitPrice = record.pricePerShare;
+                unitPrice = record.pricePerShare ?? record.price;
             }
 
             // Add record to export.
@@ -243,4 +243,4 @@ export class RevolutConverter extends AbstractConverter {
                 return "EUR";
         }
     }
-}
+}
diff --git a/src/testing/data/yahooFinanceQuoteSummaryResults.json b/src/testing/data/yahooFinanceQuoteSummaryResults.json
diff --git a/src/testing/data/yahooFinanceSearchResults.json b/src/testing/data/yahooFinanceSearchResults.json