fix: taproot derived xpub #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoquick
approved these changes
Feb 3, 2024
|
What do we do with the failing |
Apparently, the problem is related to the ehadless execution timeout, as all tests passed. |
|
It always depends on why the test fails. If it's just an issue with CI, we're not too worried about it. |
|
How exciting! Thank you. |
josediegorobles
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example seed phrase was providing the the main extended public key. i.e derivation path
mThis can be confirmed on bip32.netHere's the
mderivation in the current version:We needed to provide an
xpubthat included the taproot descriptor. Since we already had the functionwatcher_xpub, that's all that needed to be switch out.Now, if a user wants to copy the xpub for a watch only wallet; they will see
With the additional test, we can see that we now have the proper watch-only address.