Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe watcher migration #326

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Aug 7, 2023

Description

This PR allow us verifies that the xpub within the current wallet is correct. If not, move the old wallet to "legacy" and register the new wallet.

@crisdut crisdut marked this pull request as draft August 7, 2023 21:01
Copy link
Member

@josediegorobles josediegorobles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's actually pretty neat!

@cryptoquick cryptoquick marked this pull request as ready for review August 8, 2023 01:24
@cryptoquick cryptoquick added this pull request to the merge queue Aug 8, 2023
Merged via the queue into development with commit 656de08 Aug 8, 2023
5 checks passed
@cryptoquick cryptoquick deleted the CD/fix-and-merge-wallets branch August 8, 2023 01:27
@cryptoquick cryptoquick added this to the 0.6.3 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants