Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Transfers (Consig) Files #322

Merged
merged 25 commits into from
Aug 7, 2023
Merged

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Aug 5, 2023

Description

This PR intent add support to storage consig files temporally to allow users waiting the transaction is publish and confirmed in blockchain.

New Features
We add three new methods:

  • list_transfers: Allow us list all transfers related with a contract (RgbTransferDetail).
  • save_transfer: Allow us save transfer related with a contract.
  • remove_transfer: Allow us remove one or more transfer(s) related with a contract.

Changes

  • Transfer operation save consig file automatically to the sender.

Fixies

  • Resolver and Prefetch for UTXOs now check all vouts.

RgbTransferDetail (struct)
image

Closes #318
Closes #321

@crisdut crisdut self-assigned this Aug 5, 2023
@crisdut crisdut changed the base branch from JR/full_transfer_method to development August 6, 2023 14:07
@crisdut crisdut changed the base branch from development to JR/full_transfer_method August 6, 2023 14:07
@crisdut crisdut changed the base branch from JR/full_transfer_method to development August 6, 2023 14:10
@crisdut crisdut changed the base branch from development to JR/full_transfer_method August 6, 2023 14:10
@crisdut crisdut changed the base branch from JR/full_transfer_method to development August 6, 2023 14:16
Copy link
Member

@josediegorobles josediegorobles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@crisdut
Copy link
Member Author

crisdut commented Aug 7, 2023

@josediegorobles There is an example how your which parameters you need to use in your call:

// 4. Make a Self Payment
let self_pay_req = FullRgbTransferRequest {
contract_id: issuer_resp.contract_id,
iface: issuer_resp.iface,
rgb_invoice: owner_resp.invoice.to_string(),
descriptor: SecretString(issuer_keys.public.rgb_udas_descriptor_xpub.to_string()),
change_terminal: "/21/1".to_string(),
fee: PsbtFeeRequest::Value(546),
bitcoin_changes: vec![],
};

Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just one change requested.

Cargo.toml Show resolved Hide resolved
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cryptoquick cryptoquick added this pull request to the merge queue Aug 7, 2023
Merged via the queue into development with commit 1755df1 Aug 7, 2023
5 checks passed
@cryptoquick cryptoquick deleted the CD/transfers-temp branch August 7, 2023 18:48
@crisdut crisdut mentioned this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support to coin selection (bitcoin) in Full Transfer Asset Temporary Stock
3 participants