Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watcher next utxos #319

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Aug 4, 2023

Description

This PR fix the method watcher_next_utxo, avoiding duplication of the same information and listing UTXOs containing anchored contracts (previously, we prohibited this due to the problem of consecutive transfers, but this filter went unnoticed after the correction).a

@crisdut crisdut added bug Something isn't working rgb labels Aug 4, 2023
@crisdut crisdut added this to the 0.6.2 milestone Aug 4, 2023
@crisdut crisdut self-assigned this Aug 4, 2023
Copy link
Member

@josediegorobles josediegorobles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josediegorobles josediegorobles merged commit f97d7da into JR/full_transfer_method Aug 4, 2023
5 checks passed
@josediegorobles josediegorobles deleted the CD/fix-watcher-next-utxo branch August 4, 2023 15:45
github-merge-queue bot pushed a commit that referenced this pull request Aug 6, 2023
* Adding full transfer method

* Updating FullRgbTransferRequest struct

* Adding self pay to

* Bitcoin_inputs

* Match for btc_utxo

* Remove assert

* Full Transfer (PSBT + Dustless + Transfer)  (#312)

* refactor: add full transfer operation

* refactor: improviment psbt operation

* feat: add internal tests

* fix: improvement tests

* fix: coin selection

* fix: add btc change utxo

* fix: bitcoin derivation indexes

* Fix merge conflict.

* Add debug statement. Bump version to 0.6.3-rc.1.

* fix: genesis import and reduce esplora calls

* Bump bitmask-core to 0.6.3-rc.2.

* fix: blank transition for different contract types (#317)

* fix: watcher next utxos (#319)

* Bump bitmask-core to 0.6.3-rc.4.

* Not skipping is_spent in allocationdetail

* Adding watcher_unspent_utxos to web interface

* Switch to defaulting to blockstream Esplora API. Update to bitmask-core 0.6.3-rc.5.

* Tests are failing. Trying mempool.space API again.

* Update to using our own mempool instance.

* Configure to use our proxy to external mempool.

---------

Co-authored-by: Armando CD <[email protected]>
Co-authored-by: Hunter Trujillo <[email protected]>
Co-authored-by: Armando Dutra <[email protected]>
Co-authored-by: Hunter Beast <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Aug 7, 2023
* Adding full transfer method

* Updating FullRgbTransferRequest struct

* Adding self pay to

* Bitcoin_inputs

* Match for btc_utxo

* Remove assert

* Full Transfer (PSBT + Dustless + Transfer)  (#312)

* refactor: add full transfer operation

* refactor: improviment psbt operation

* feat: add internal tests

* fix: improvement tests

* fix: coin selection

* fix: add btc change utxo

* fix: bitcoin derivation indexes

* Fix merge conflict.

* Add debug statement. Bump version to 0.6.3-rc.1.

* fix: genesis import and reduce esplora calls

* Bump bitmask-core to 0.6.3-rc.2.

* fix: blank transition for different contract types (#317)

* fix: watcher next utxos (#319)

* Bump bitmask-core to 0.6.3-rc.4.

* Not skipping is_spent in allocationdetail

* Adding watcher_unspent_utxos to web interface

* feat: temp transfers

* fix: prefetch and resolver for utxos

* feat: add bitcoin change addrs

* feat: automatically coin selection

* Add wasm_bindgen to decode_invoice

---------

Co-authored-by: Jose D Robles <[email protected]>
Co-authored-by: Hunter Trujillo <[email protected]>
Co-authored-by: Hunter Beast <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rgb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants