Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashed Name with Alternative Name Checks #297

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Jul 24, 2023

Description

I moved hashed to rgb/carbonado.rs to guarantees always we retrieve and stock with correct file name. Also, we maintain the alternative name check in retrieve operations (see details #279 and #289).

@crisdut crisdut requested a review from cryptoquick July 24, 2023 23:41
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements! Just a couple changes and suggestions.

build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
src/rgb/constants.rs Outdated Show resolved Hide resolved
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@cryptoquick cryptoquick merged commit a01debd into HT/hashed-stashed-name Jul 25, 2023
5 checks passed
@cryptoquick cryptoquick deleted the CD/hashed-stashed-name branch July 25, 2023 15:53
@cryptoquick cryptoquick added this to the 0.6.1 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants