Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update strict-type to v1.5 (import from genesis fix) #265

Merged
merged 6 commits into from
Jul 13, 2023
Merged

Update strict-type to v1.5 (import from genesis fix) #265

merged 6 commits into from
Jul 13, 2023

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Jul 11, 2023 •
edited
Loading

Description

This PR allows us import contracts by genesis, update strict-types to v1.5 and bump rgblibs.

Include in this PR:

Closes #263

@crisdut crisdut requested a review from cryptoquick July 11, 2023 07:35
@crisdut crisdut marked this pull request as draft July 11, 2023 07:35
@crisdut crisdut changed the title Import from genesis Import from genesis and update to Strict-Type 1.5 Jul 13, 2023
@crisdut crisdut changed the title Import from genesis and update to Strict-Type 1.5 Import from genesis and bump strict-type to v1.5 Jul 13, 2023
@crisdut crisdut marked this pull request as ready for review July 13, 2023 04:28
@crisdut crisdut changed the title Import from genesis and bump strict-type to v1.5 Update strict-type to v1.5 (import from genesis fix) Jul 13, 2023
@crisdut crisdut added bug Something isn't working dependencies Pull requests that update a dependency file rgb wasm labels Jul 13, 2023
@crisdut crisdut added this to the 0.6.1 milestone Jul 13, 2023
josediegorobles
josediegorobles approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@josediegorobles josediegorobles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cryptoquick
cryptoquick approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cryptoquick cryptoquick added this pull request to the merge queue Jul 13, 2023
Merged via the queue into development with commit b3a82ad Jul 13, 2023
5 checks passed
@cryptoquick cryptoquick deleted the CD/import-genesis branch July 13, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoquick cryptoquick cryptoquick approved these changes

@josediegorobles josediegorobles josediegorobles approved these changes

Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file rgb wasm
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

Error importing assets
3 participants
@crisdut @cryptoquick @josediegorobles