Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Issue (strict-types 1.3.0) #253

Merged
merged 21 commits into from
Jul 10, 2023
Merged

Re-Issue (strict-types 1.3.0) #253

merged 21 commits into from
Jul 10, 2023

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Jun 29, 2023

Description

This PR allows you to create a re-issue operation for contracts issued but not transferred.

This action was taken because of the compatibility break generated in strict-types version 1.3.0

Copy link
Member

@josediegorobles josediegorobles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lGTM

@crisdut crisdut marked this pull request as ready for review June 29, 2023 18:01
@crisdut
Copy link
Member Author

crisdut commented Jul 3, 2023

Guys, I will update this PR with the latest version of the strict-types; I think I will finish today.

@cryptoquick
Copy link
Member

Awesome! Looking forward to it!

crisdut and others added 3 commits July 10, 2023 09:55
Turn some unwraps into ? to better propagate errors instead of panics.
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cryptoquick cryptoquick merged commit e959d7d into CD/conseq-transfers Jul 10, 2023
3 checks passed
@cryptoquick cryptoquick deleted the CD/re-issue branch July 10, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants