Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.py to add a general try catch on error, change slider ranges #9

Conversation

yavuzitconsulting
Copy link

(commit message: add general try/catch to stop the application from window.close() on error, changed range slider for steps, changed range slider for video length)

it is impossible to troubleshoot this application in this phase when the application window (GUI) and console window closes whenever an exception occurs, i propose a general try/catch and log, so on fatal exceptions, it is at least possible to view the error message, even if the GUI crashes, this might be more helpful to development, but at this moment, i figure the community would like to report issues with their actual exception messages rather than not reporting them at all.

i also took the freedom to adjust the range of the steps and length slider, because i was able to create high-step and high-length videos without any issues, it just takes longer, maybe we can add a warning if the range exceeds n seconds.

thank you for your time, and for the tool, very happy to play around with this.

add general try/catch to stop the application from window.close() on error, changed range slider for steps, changed range slider for video length
@yavuzitconsulting
Copy link
Author

i noticed some errors that happened because vs-code auto-refactored the code, i will fix this and submit the request anew

@yavuzitconsulting yavuzitconsulting deleted the yitc-patch-generalexceptions_sliderranges branch August 5, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant