Feat: Exception message instead of closing window on error, video-len… #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, an exception during runtime closes the application, leaving no possible way to recover the exception message.
Instead, i propose a general try catch and logging of any exception, which might not be the best possible implementation, but i am no python developer and would need a lot of time to understand the inner workings of indentation, which i do not have the patience to learn, just kidding, but i honestly hate it.
I also propose to expand the video-length slider to allow up to 60 seconds of video generation, it works flawlessly, but takes a lot of time.
I would also like to plug that i created a visioncrafter subreddit for you guys, since i was unable to find any community engagement, tutorials or documentation, i am hoping the community will help each other out.
Sorry for the big commit, it is mainly just about 4 lines of code, but the indentation necessary for the try/catch is encapsulating the entire main function, therefore touching all of these lines.