Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Exception message instead of closing window on error, video-len… #10

Conversation

yavuzitconsulting
Copy link

@yavuzitconsulting yavuzitconsulting commented Aug 5, 2023

At the moment, an exception during runtime closes the application, leaving no possible way to recover the exception message.
Instead, i propose a general try catch and logging of any exception, which might not be the best possible implementation, but i am no python developer and would need a lot of time to understand the inner workings of indentation, which i do not have the patience to learn, just kidding, but i honestly hate it.

I also propose to expand the video-length slider to allow up to 60 seconds of video generation, it works flawlessly, but takes a lot of time.

I would also like to plug that i created a visioncrafter subreddit for you guys, since i was unable to find any community engagement, tutorials or documentation, i am hoping the community will help each other out.

Sorry for the big commit, it is mainly just about 4 lines of code, but the indentation necessary for the try/catch is encapsulating the entire main function, therefore touching all of these lines.

…gth range slider from max 6 seconds to 60 seconds
@diStyApps
Copy link
Owner

Hey, thank you very much. i tried 30sec its kinda working consistency wise, and as you said takes very long time.
I will increase the limit to 60 sec with a tool tip warning, till i add cancellation button.

The crash happens i guess when you also add music because of audiocraft 30 sec limit,
So i plan to add creation of separated audio file that you can attach later to videos or whatever else.
I plan to refactor the entire code and add better event handling, its just messy right now i just wanted to make it work and share it, and hoped or the community to help test what i didn't have time to test.

i will add link to your subreddit next update.

@yavuzitconsulting
Copy link
Author

thank you very much, much appreciated, i am going to close this PR today if it does not proceed due to the changes you are planning. have a nice Sunday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants