add and delete dashboard observe changes #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since, there's no id till we sync so I am left with no option then to compare with dashboard name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewPager observe changes now on adding and deleting dashboards.
FragmentStatePageAdapter implemented.
Smooth scroll to the added or removed dashboard.
onLoadFinished in DashboardViewPagerFragment is called twice and it is necessary to be called twice, first when saved dashboard locally and second when synced from server. But reflecting added or removed dashboard is called once only, the second time it just updates the data in DashboardAdapter.