V0 -> V1 POC review #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhABC
reviewed
Mar 13, 2020
| uint256 daiAmount | ||
| ) external returns (uint256 backstopTokensMinted) { | ||
| require( | ||
| _status == Status.ACCEPTING_DEPOSITS, |
There was a problem hiding this comment.
I would personally simplify and try to only prevent deposits when auctions are over.
| uint256 daiBalance = _DAI.balanceOf(address(this)); | ||
|
|
||
| // Combine Dai locked in auctions with the balance on the contract. | ||
| uint256 combinedDai = daiLockedInAuctions.add(daiBalance); |
There was a problem hiding this comment.
Need to make sure that it's not possible to have a small amount of dai locked in auction that can't be withdrawn, otherwise this call might always end up throwing where daiReeemed end up always > than daiBalance).
| require( | ||
| _status == Status.ACCEPTING_DEPOSITS, | ||
| "Cannot activate again after a prior activation." | ||
| ); |
There was a problem hiding this comment.
Someone could freeze deposit by spamming activate().
Plus once activated, how do we re-enable deposits? I only see it in Constructor, so looks like the system could permanently prevent further deposits once we have at least 50k DAI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.