Upgrade to Rails 7.2 #391
Merged
Upgrade to Rails 7.2 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only issue is with Rubocop. I'm generally in favour of sticking to the community defaults, but you'll pry my String instance doubles out of my cold dead hands: they allow specs to run completely in isolation. The enum issue was autofixed and would have caused an exception in a later rails.
Just upgrade the rails version and bundle - nothing else. Surprisingly the tests still pass.
Decided to disable config.active_record.attributes_for_inspect - maybe I'll change my mind later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.