Upgrade ruby (3.3.4) and all gems (Rails 7.1.4) #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of changes here:
- config seems to now require an array rather than a string
- SASS has made some breaking changes such that all top level rules
should go at the top.
The extra gems are now no longer included
...for dev and test. secrets.yml is deprecated and will be removed in Rails 7.2
I guess CI runs in test mode? But running `rake` from the command line runs in the default env (development)? Rails.env.local? is introduced in Rails 7.1 and is just a shorthand for test or development.
The date range thing here seems a bit too clever for its own good, but if it's the rubocop default then let's go with it. Cops: - Rails/WhereRange - Rails/EnumSyntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.