Stricter RSpec tests #375
Merged
Stricter RSpec tests #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a doubled constant doesn't exist then Rails won't verify methods on
it, so we generally want to verify that they do exist. However, we
_don't_ want to verify them in two scenarios:
- when running isolated spec files (since those constants won't be
loaded, so would result in verification failures)
- when TDDing a file (isolated or not) which uses collaborators which
don't exist yet
In both of those scenarios we're running a single file, so we can use
that as a proxy.
Note that if we were to add it to rails_helper then it would only be
applied to files which were loaded after the first file which loaded
rails helper, which would lead to inconsistent behaviour because of our
random loading.
Found using rsp --warnings
When we use `require`, Ruby makes sure that we only load the file once,
but since here we're explictly pushing things onto the load path we need
to do that check ourself.
Found using bin/rspec --warnings, which showed the following:
/Users/dgmstuart/dev/swing-out-london/config/locales/en.rb:3: warning: method redefined; discarding old ordinal_day
/Users/dgmstuart/dev/swing-out-london/config/locales/en.rb:3: warning: previous definition of ordinal_day was here
/Users/dgmstuart/dev/swing-out-london/config/locales/en.rb:7: warning: method redefined; discarding old human_date
/Users/dgmstuart/dev/swing-out-london/config/locales/en.rb:7: warning: previous definition of human_date was here
...since these methods are defined in the locale file which is being
loaded here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.