Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDO: Support for PDO::ERRMODE_EXCEPTION #393

Open
wants to merge 2 commits into
base: v4.2
Choose a base branch
from

Conversation

dakujem
Copy link
Contributor

@dakujem dakujem commented Jun 22, 2021

  • new feature, no existing code will break (full bc)

I added support for PDO in PDO::ERRMODE_EXCEPTION error mode using a single try-catch block.

👉 Since in PHP 8 PDO::ERRMODE_EXCEPTION is the default, this is also useful for your master branch.

I have a use case where I need to share PDO resource and it's set with exception errmode, this solves the issue for the 4.2 branch.

@dg dg force-pushed the v4.2 branch 2 times, most recently from 96f5def to 0b394a9 Compare June 30, 2021 10:48
@dg
Copy link
Owner

dg commented Jun 30, 2021

There is a older attempt to implement it #293

@dakujem
Copy link
Contributor Author

dakujem commented Jul 1, 2021

That PR solves a different issue.
And since the PR(s) mentioned are over 3 years old, I'm not expecting them merged any time soon.

This PR does not introduce BC break in any way, it only adds the option to use the exception error mode without any change in behaviour of dibi.

@dakujem
Copy link
Contributor Author

dakujem commented Aug 2, 2023

bump.

@dg dg force-pushed the v4.2 branch 2 times, most recently from 584f7d0 to cb0cf4b Compare August 9, 2023 14:15
@dg dg force-pushed the v4.2 branch 2 times, most recently from dfd4707 to c8457ab Compare September 29, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants