Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): sol txns list #4137

Merged
merged 41 commits into from
Jan 13, 2025
Merged

feat(frontend): sol txns list #4137

merged 41 commits into from
Jan 13, 2025

Conversation

loki344
Copy link
Collaborator

@loki344 loki344 commented Jan 8, 2025

Note

first: #4133

Motivation

Add Components to display the SOL txns.

Changes

Implement SolTransactions.

Tests

Showcasing:

Bildschirmaufnahme.2025-01-08.um.21.20.30.mov

AntonioVentilii and others added 30 commits January 7, 2025 13:15
…-in-solanaHttpRpc' into feat(frontend)/sol-txn-api
…ntend)/sol-txn-api

# Conflicts:
#	src/frontend/src/sol/providers/sol-rpc.providers.ts
loki344 and others added 8 commits January 8, 2025 17:24
# Conflicts:
#	src/frontend/src/sol/api/solana.api.ts
#	src/frontend/src/sol/components/transactions/SolTransactionModal.svelte
#	src/frontend/src/sol/derived/sol-transactions.derived.ts
#	src/frontend/src/sol/schedulers/sol-wallet.scheduler.ts
#	src/frontend/src/sol/services/sol-transactions.services.ts
#	src/frontend/src/tests/sol/api/solana.api.spec.ts
#	src/frontend/src/tests/sol/schedulers/sol-wallet.scheduler.spec.ts
#	src/frontend/src/tests/sol/services/sol-transactions.services.spec.ts
# Conflicts:
#	src/frontend/src/sol/components/transactions/SolTransactionsSkeletons.svelte
#	src/frontend/src/tests/sol/components/transactions/SolTransactionsSkeletons.spec.ts
@loki344 loki344 marked this pull request as ready for review January 12, 2025 15:41
@loki344 loki344 requested a review from a team as a code owner January 12, 2025 15:41
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks

{/each}
</SolTransactionsScroll>
{/if}
{#if $solTransactions.length === 0}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would use else if here

@loki344 loki344 enabled auto-merge (squash) January 13, 2025 17:13
@loki344 loki344 merged commit 1e6d770 into main Jan 13, 2025
21 checks passed
@loki344 loki344 deleted the feat(frontend)/sol-txns branch January 13, 2025 17:16
loki344 added a commit that referenced this pull request Jan 13, 2025
# First

#4137

# Motivation

Add SOL transactions in Activity page.

# Changes

- Add Typing
- Add Txn component
- Add functionality in mapping

# Tests

Unit tests extended.



https://github.com/user-attachments/assets/27c6f218-5f32-49dc-b549-181841bfb07f

---------

Co-authored-by: Antonio Ventilii <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants