feat(frontend): transaction ui with variant and templating #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Svelte v5 seems to be stricter in terms of typing, which causes the linter to fail in #3929 when the
TransactionUIis used to create asvelte:component. After reviewing the issue, I also noticed that we are spreading thetransactionwithin thetransactionUiwhile mixing it with atoken. From a typing perspective, I believe it would be safer to maintain a clear separation between these two pieces of information.This PR addresses both issues.
Changes
svelte:componentby a direct usage of the component in the template