feat(frontend): listener templating #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii
approved these changes
Dec 11, 2024
| {#if isNullish(token) || $authNotSignedIn} | ||
| <NoListener> | ||
| <slot /> | ||
| </NoListener> |
There was a problem hiding this comment.
shall we delete NoListener at this point? and leave just <slot />, and use it as fallback instead of EthListener?
There was a problem hiding this comment.
I was thinking doing that in another PR.
peterpeterparker
added a commit
that referenced
this pull request
Dec 11, 2024
# Motivation Follow-up of #3937. We do not need the `NoListener` anymore and can simplify with a slot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Migration to Svelte v5 (#3929) involves replacing the ComponentType. While updating the Listener, a minor TypeScript issue was identified. We use a
svelte:componentthat maps a token property, which may or may not be present, and can sometimes be set or unset. This approach works because the component is assigned to a state variable, but it is not fully TypeScript-compliant. To address this, we can leverage the template to correctly mount the listener.