Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: signer ready #23

Merged
merged 22 commits into from
Jul 31, 2024
Merged

feat: signer ready #23

merged 22 commits into from
Jul 31, 2024

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Jul 30, 2024

Motivation

When a connection is established, the signer should dispatch "READY" to the relying party.

Notes

The origin assertions was provided in another PR #29 to narrow its functionality and ease review.

Changes

  • Implement reception of reception of ICRC29_STATUS and dispatch ICRC29_READY

@peterpeterparker peterpeterparker marked this pull request as ready for review July 31, 2024 10:41
@peterpeterparker peterpeterparker requested a review from a team as a code owner July 31, 2024 10:41
Copy link

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you meant #29 in the description.

Looks good to me

@peterpeterparker
Copy link
Member Author

I guess you meant #29 in the description.

Ah yes, sorry. Updated the description, thanks.

@peterpeterparker peterpeterparker merged commit b572b19 into main Jul 31, 2024
7 checks passed
@peterpeterparker peterpeterparker deleted the feat/signer-ready branch July 31, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants