-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experiment: mechanism for interacting with external Wasm components #4580
Draft
rvanasa
wants to merge
40
commits into
master
Choose a base branch
from
ryan/component-call
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…component-call
@rvanasa I took a look and (hopefully) got CI working for you in #4584. The problem was that moc -t doesn't even enter compile.ml, so you weren't generating the error when just running moc -t (as the tests in test/fail (which are mostly type checker test do). Feel free to merge into your branch or ignore... |
… into ryan/component-call
… into ryan/component-call
rvanasa
force-pushed
the
ryan/component-call
branch
from
July 19, 2024 22:20
1e7ccb2
to
4b95c4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a standardized import which can be used for cross-language interoperability via the Wasm component model specification.
Progress:
component.call
in compiled Wasm modulecomponentCall
prim function-import-component
flag (e.g.moc -wasi-system-api -import-component ...
)M0200
) when trying to use this feature without the-import-component
flagNat32
arg withBlob
Nat32
return type withBlob
Next steps
wit:component:call
to support arbitrary component imports?Note that this only works in runtimes with support for the component model:
wasm_component_layer
.An alternate approach would be to enable passing the names of arbitrary Wasm imports. While this seems like it would be beneficial at first glance, the component model architecture tends to favor a pattern of defining a standard interface (for example, the WASI CLI world) and then "plugging" exports into corresponding imports (see WAC for how this specifically works).
The current approach follows this pattern with the following WIT world:
It's possible to plug a Rust component into this interface using something similar to the following WAC composition: