feat: allow anonymous query and read_state requests with invalid ingress_expiry #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
changed the title
THLO
reviewed
Oct 22, 2024
Co-authored-by: Thomas Locher <[email protected]>
Dfinity-Bjoern
approved these changes
Oct 22, 2024
fspreiss
reviewed
Oct 24, 2024
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Oct 28, 2024
…s and read_state requests (#1768) Adapts ingress message validation such that the ingress_expiry check is skipped for anonymous queries and anonymous read_state requests. Implements the interface specification changes from dfinity/interface-spec#343.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows anonymous
queryandread_staterequests with invalidingress_expiry. The motivation is to allow users retrieving the certified subnet time via an anonymous read state request without having to provide a validingress_expiry(which they might not be able to do if they don't know the subnet time).