Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine definition of path lookup values #213

Merged
merged 6 commits into from
Aug 9, 2023

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Aug 9, 2023

This PR turns the explanation of path lookup values into more formal definition of their meaning.

@mraszyk mraszyk requested a review from a team as a code owner August 9, 2023 11:02
@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for ic-interface-spec ready!

Name Link
🔨 Latest commit e2e4d9f
🔍 Latest deploy log https://app.netlify.com/sites/ic-interface-spec/deploys/64d3b47dc5914d0008e770ad
😎 Deploy Preview https://deploy-preview-213--ic-interface-spec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

spec/index.md Outdated Show resolved Hide resolved
spec/index.md Show resolved Hide resolved
Copy link
Member

@Dfinity-Bjoern Dfinity-Bjoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Since the change proposed by Oleksandr does not change the observable behavior, I think either way is fine from the spec compliance perspective.

@mraszyk mraszyk merged commit f114051 into master Aug 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants