feat(node): Configuration revamp (SetupOS integration) #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbattat
commented
Dec 19, 2024
andrewbattat
commented
Dec 19, 2024
andrewbattat
commented
Dec 19, 2024
|
Passed hourly and bare metal installation test! |
andrewbattat
commented
Dec 19, 2024
frankdavid
reviewed
Dec 19, 2024
frankdavid
approved these changes
Jan 7, 2025
Bownairo
reviewed
Jan 8, 2025
Bownairo
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE-1360
The IC-OS tool has been created, but not yet used by the IC-OS: #1539
This PR integrates the config tool into SetupOS. The config tool is utilized for config sanitization, organization, and access.
Note that the old config is still being passed to HostOS, so this PR should have no impact on HostOS or GuestOS