chore: simplify bitcoin header validation #3257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailjianu1
changed the title
rumenov
reviewed
Dec 19, 2024
rumenov
reviewed
Dec 19, 2024
rumenov
reviewed
Dec 20, 2024
| /// Validates if a header's timestamp is valid. | ||
| /// Bitcoin Protocol Rules wiki https://en.bitcoin.it/wiki/Protocol_rules says, | ||
| /// "Reject if timestamp is the median time of the last 11 blocks or before" | ||
| fn is_timestamp_valid(store: &impl HeaderStore, header: &BlockHeader) -> bool { |
There was a problem hiding this comment.
This is the only check I am a bit hesitant to keep since it is documented as part of the BTC protocol rules
https://en.bitcoin.it/wiki/Protocol_rules
Do you know if testnet and testnet4 follow this particular check ?
rumenov
reviewed
Dec 20, 2024
rumenov
reviewed
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all checks regarding the timestamp of the header in the bitcoin adapter.
This is meant to simplify the header validation itself, as the checks are anyway made in the bitcoin canister.
The main check that remains is the PoW check, which is by far the hardest to "abuse".
Note that checks such as:
are already made in the adapter.