chore: do not use time of next round in tests #2455
Merged
+136
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorydemay
approved these changes
Nov 6, 2024
mbjorkqvist
approved these changes
Nov 6, 2024
alin-at-dfinity
approved these changes
Nov 7, 2024
adambratschikaye
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
If I'm understanding this correctly, executing a round will advance the time by EXECUTE_ROUND_TIME_INCREMENT, unless the time has already been manually advanced via advance_time. Could we add some documentation about that on the advance_time and time methods?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids querying the time of next round in tests by advancing time so that time does not grow implicitly when executing a round. The motivation for this change is to clean up the StateMachine test API.