feat(BOUN-1233): rework ic-boundary CLI, bump ic-gateway #2451
Conversation
| @@ -156,25 +156,29 @@ impl BoundaryNodeManager { | |||
|
|
|||
| // TODO: Should these values be settable via config? | |||
There was a problem hiding this comment.
Would this clean up the code here and/or reduce the frequency of changes?
There was a problem hiding this comment.
No idea. Changes would anyway happen, whether in code or the config.
There was a problem hiding this comment.
Yes, but depending on where this config would live you might at least no longer have to block on consensus review
There was a problem hiding this comment.
Hmm, well if you have an idea where to put that - I guess we don't really care how to specify those args and can use the config. I'm not really familiar with the orchestrator-related parts. Also we can take env vars if that would be easier to do.
There was a problem hiding this comment.
For the replica we pass the ic.json5 config file here, for instance
ic-boundaryCLI: re-group & rename, move http client & server CLI toic-bn-libic-boundarynow gets configured through env vars likeic-gateway