Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cketh/ckerc20): consolidate log scrapings #2449

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

gregorydemay
Copy link
Member

@gregorydemay gregorydemay commented Nov 5, 2024

Follow-up on #2324 and #2369 to consolidate log scrapings done by the ckETH minter.

Added

Information related to the state of the scraping of the new deposit with subaccount helper smart contract:

  1. Last scraped block number to MinterInfo.
  2. State of scraping (address and last scraped block number) to the minter dashboard.
  3. Metric for the last scraped block number.

Changed

Refactor State to have a container (LogScrapings) to aggregate all log scrapings. This allows to:

  1. Automatically display the state of a new log scraping to the minter dashboard. Information related to helper smart contracts was moved to its own section.
  2. Automatically add a metric for the last scraped block number.
  3. Recall to add an event that is registered during pre-upgrade to save the last scraped block number to stable memory.

@gregorydemay gregorydemay changed the title refactor(cketh/cker20): log scrapings feat(cketh/cker20): consolidate log scrapings Nov 6, 2024
@github-actions github-actions bot added feat and removed refactor labels Nov 6, 2024
@gregorydemay gregorydemay marked this pull request as ready for review November 6, 2024 13:31
@gregorydemay gregorydemay requested a review from a team as a code owner November 6, 2024 13:31
Copy link
Member

@ninegua ninegua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

nit: there is a typo in your PR title, s/cker20/ckerc20/

@gregorydemay gregorydemay changed the title feat(cketh/cker20): consolidate log scrapings feat(cketh/ckerc20): consolidate log scrapings Nov 7, 2024
@gregorydemay
Copy link
Member Author

Thanks @ninegua for the review!

nit: there is a typo in your PR title, s/cker20/ckerc20/

Good catch!

@gregorydemay gregorydemay added this pull request to the merge queue Nov 7, 2024
Merged via the queue into master with commit 46c7815 Nov 7, 2024
35 checks passed
@gregorydemay gregorydemay deleted the gdemay/XC-222-dashboard branch November 7, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants