feat(BOUN-1236): add skeleton service methods and wrap with authorization #2428
+338
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikonor
force-pushed
the
or-salt-log-2
branch
from
787befd
to
60a426b
Compare
rikonor
force-pushed
the
or-salt-log-3
branch
from
91ed538
to
d9519a0
Compare
nikolay-komarevskiy
approved these changes
Nov 5, 2024
| } | ||
|
|
||
| pub trait Authorize { | ||
| fn authorize(&self, p: &Principal) -> Result<(), AuthorizeError>; |
There was a problem hiding this comment.
Suggestion: use is_authorized(). Authorize could also mean that You grant authorization.
| fn register(_pubkey: Vec<u8>) -> RegisterResponse { | ||
| unimplemented!() | ||
| fn register(pubkey: Vec<u8>) -> RegisterResponse { | ||
| match REGISTRATOR.with(|v| v.borrow().register(&pubkey)) { |
There was a problem hiding this comment.
Consider moving these matching statements into the register() function. This would make the canister method thinner and easier. Plus the unit test will cover all the logic, including error handling. Also consider implementing conversion of errors into each other.
r-birkner
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds initial empty implementations for the canister methods and also adds authorization to the canister endpoints. A follow-up will add the relevant logic to the canister method implementations.