-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [UTP-242] [v3] Make subnet replica version of latest block available to execution environment #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
@consensus
@execution
@ic-message-routing-owners
@pocket-ic
@languages
labels
Oct 25, 2024
mraszyk
approved these changes
Oct 25, 2024
alin-at-dfinity
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MR changes LGTM. Thank you.
dsarlis
approved these changes
Oct 25, 2024
crusso
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drun changes LGTM
Sawchord
approved these changes
Oct 25, 2024
michael-weigelt
force-pushed
the
mwe/subnet_metrics_exe
branch
from
October 28, 2024 09:03
2cba340
to
35e3b31
Compare
aterga
pushed a commit
that referenced
this pull request
Oct 29, 2024
…lable to execution environment (#2248) This is an alternative to #2248 and #2082 This PR passes the running replica version to the execution environment, from where it can be used [in a future management canister call.](dfinity/interface-spec#351): #2202 --------- Co-authored-by: Michael Weigelt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2248 and #2082
This PR passes the running replica version to the execution environment, from where it can be used in a future management canister call.: #2202