build: vite v6 #541
Draft
build: vite v6 #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> If bundling, conditions should include development or production. If not bundling, conditions or NODE_ENV should include development or production. See https://www.npmjs.com/package/esm-env for tips on setting conditions in popular bundlers and runtimes.
This was referenced Dec 9, 2024
peterpeterparker
added a commit
that referenced
this pull request
Dec 9, 2024
# Motivation Fix an error - that blocks the build - detected when migrating to Svelte v5 in #541: > error during build: [vite-plugin-svelte] [plugin vite-plugin-svelte] src/routes/(page)/browser/+page.svelte (27:2): src/routes/(page)/browser/+page.svelte:27:2 `<tr>` cannot be a child of `<table>`. `<table>` only allows these children: `<caption>`, `<colgroup>`, `<tbody>`, `<thead>`, `<tfoot>`, `<style>`, `<script>`, `<template>`. The browser will 'repair' the HTML (by moving, removing, or inserting elements) which breaks Svelte's assumptions about the structure of your components # Changes - Add `tbody`
peterpeterparker
added a commit
that referenced
this pull request
Dec 9, 2024
# Motivation Fix a linter error reported by latest Svelte v5 linter in #541: > Self-closing HTML tags for non-void elements are ambiguous — use `<div ...></div>` rather than `<div ... />`(element_invalid_self_closing_tag) svelte/valid-compile # Changes - Replace self closing tags. e.g. `<div />` -> `<div></div>`
peterpeterparker
added a commit
that referenced
this pull request
Dec 9, 2024
# Motivation Fix an error - that blocks the build - detected when migrating to Svelte v5 in #541: > error during build: [vite-plugin-svelte] [plugin vite-plugin-svelte] src/lib/components/MenuItem.svelte (73:10): src/lib/components/MenuItem.svelte:73:10 Nesting selectors can only be used inside a rule or as the first selector inside a lone `:global(...)` It seems that the rule is actually unused / not applied. Therefore I remove it. # Changes - Remove nested CSS global rule.
|
We have an issue upgrading vitest and testing-library to support v5. It seems that having Also made a sample repo to reproduce the issue https://github.com/peterpeterparker/svelte-vite-testing-library-css |
This was referenced Dec 9, 2024
peterpeterparker
changed the title
|
Let's use this PR to migrate to vite v6. Currently blocked because of an incompatibility in Vitest v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Svelte v5 and notably
@sveltejs/vite-plugin-svelteuses Vite v6 in their last version. Therefore we also want to keep the pace and use those version.