Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop Host header in https outcall request #1068

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ninegua
Copy link
Member

@ninegua ninegua commented Dec 11, 2024

Having the Host header seems to cause problem with https outcalls using http/2, which is currently the case.

It is best to remove this setting from examples because many people (me included) would copy them and later have a hard time figuring out what could be the problem if something goes wrong.

@ninegua ninegua requested a review from a team as a code owner December 11, 2024 11:43
Copy link
Member

@marc0olo marc0olo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree. thanks @ninegua!

@marc0olo
Copy link
Member

@ninegua seems like you need to resolve some conflicts first 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants