chore: adding neuron detection tests #902
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasa-tomic
approved these changes
Sep 11, 2024
rs/cli/src/unit_tests/ctx_init.rs
Outdated
| @@ -1,4 +1,4 @@ | |||
| use std::{path::PathBuf, str::FromStr}; | |||
| use std::{path::PathBuf, process::Command, str::FromStr}; | |||
There was a problem hiding this comment.
Do we plan to use this code for non-unit tests as well?
If so, it would make sense to rename the directory from unit_tests to just plain tests since it's shorter and does not carry less information.
There was a problem hiding this comment.
I don't know. For the moment these are not even "unit tests", most are, but some do integrate with real services (Like governance canister). So what is your suggestion?
There was a problem hiding this comment.
How about renaming to tests then?
DFINITYManu
approved these changes
Sep 13, 2024
|
Will mark as draft, still can't fully replicate hsm with softhsm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to start adding tests for our neuron detection code with hsm.
What is done:
SignerrequirementNeuronrequirement