more consistently use Nakamoto coefficient term

dfinity · Aug 16, 2024 · 9a88b91 · 9a88b91
1 parent 6e31be8
commit 9a88b91
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/dashboard/packages/app/src/components/subnets/SubnetChangePage.tsx b/dashboard/packages/app/src/components/subnets/SubnetChangePage.tsx
@@ -140,7 +140,7 @@ export const SubnetChangePage = ({ network }: { network: string }) => {
           <Grid item xs={12}>
             <Chip label="Vote on the proposal" component="a" href={`https://nns.ic0.app/proposal/?proposal=${change?.proposal_id}`} clickable target='_blank' icon={<HowToVoteIcon style={{ color: purple[500] }} />} />
           </Grid>
-          <Typography variant="h5" style={{ marginLeft: 16 }}>Decentralization scores</Typography>
+          <Typography variant="h5" style={{ marginLeft: 16 }}>Decentralization Nakamoto coefficients</Typography>
           <Grid item xs={12} container direction='column'>
 
             {Object.entries(change?.score_after?.coefficients ?? {}).map(([key, _]) => {
@@ -158,7 +158,7 @@ export const SubnetChangePage = ({ network }: { network: string }) => {
           </Grid>
           {change?.comment && <Grid item>
             <Alert variant="filled" severity="warning">
-              { change?.comment.split("\n").filter(l => l).map((line, index) => { if (index == 0) {return line} else { return <li>{line}</li> } }) }
+              {change?.comment.split("\n").filter(l => l).map((line, index) => { if (index == 0) { return line } else { return <li>{line}</li> } })}
             </Alert>
           </Grid>
           }

diff --git a/rs/cli/src/commands/subnet/create.rs b/rs/cli/src/commands/subnet/create.rs
@@ -22,8 +22,8 @@ pub struct Create {
     #[clap(long, num_args(1..))]
     pub only: Vec<String>,
 
-    #[clap(long, num_args(1..), help = r#"Force t he inclusion of the provided nodes for replacement,
-regardless of the decentralization score"#)]
+    #[clap(long, num_args(1..), help = r#"Force the inclusion of the provided nodes for replacement,
+regardless of the decentralization coefficients"#)]
     pub include: Vec<PrincipalId>,
 
     /// Motivation for replacing custom nodes

diff --git a/rs/cli/src/commands/subnet/replace.rs b/rs/cli/src/commands/subnet/replace.rs
@@ -41,7 +41,7 @@ algorithm"#
     pub only: Vec<String>,
 
     /// Force the inclusion of the provided nodes for replacement, regardless
-    /// of the decentralization score
+    /// of the decentralization coefficients
     #[clap(long, num_args(1..))]
     pub include: Vec<PrincipalId>,
 

diff --git a/rs/decentralization/src/lib.rs b/rs/decentralization/src/lib.rs
@@ -74,7 +74,11 @@ impl From<&network::SubnetChange> for SubnetChangeResponse {
 
 impl Display for SubnetChangeResponse {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
-        writeln!(f, "Decentralization score changes for subnet {}:\n", self.subnet_id.unwrap_or_default())?;
+        writeln!(
+            f,
+            "Decentralization Nakamoto coefficient changes for subnet {}:\n",
+            self.subnet_id.unwrap_or_default()
+        )?;
         let before_individual = self.score_before.scores_individual();
         let after_individual = self.score_after.scores_individual();
         self.score_before