feat: unstable dynamic routing feature #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwshang
approved these changes
Sep 23, 2024
| use thiserror::Error; | ||
| use tokio::{ |
There was a problem hiding this comment.
@adamspofford-dfinity even though futures_util can run with tokio runtime, i'm not sure the performance will be as good as with pure tokio. As tokio specific utilities like tasks are optimized for tokio, so i'm a bit concerned with the decision to remove it.
There was a problem hiding this comment.
i get the rationale to make the code work for wasm builds too, but don't like that standard build will potentially loose in performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final design of dynamic routing in the agent is not complete and other teams want to be already using it, so this merges the original design with the minimum number of changes to support WASM, and exports it under the feature
_internal_dynamic-routing. Work on the final design will continue in the background.