-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate a file with a list of API seeds at compile time #578
feat: generate a file with a list of API seeds at compile time #578
Conversation
4d2428e
to
300288b
Compare
300288b
to
ac6f084
Compare
|
||
// An initial seed list of API nodes used for fetching all existing API nodes. | ||
const API_SEED_NODES: [&str; 4] = [ | ||
"ic0.app", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ic0.app", | |
"icp-api.io", | |
"ic0.app", | |
"icp0.io", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could yes, but should we? Will these domain work as seeds in the future? I was actually even reluctant to put ic0.app
here, as it is not an API node.
b3bf4fb
to
4d48a37
Compare
4d48a37
to
c77c92b
Compare
Description
Using the build script approach (
build.rs
), we auto-generate anapi_seed_nodes.rs
file, containing a full list of existing API nodes. This generation is done at compile time. The generatedapi_seed_nodes.rs
file is further used as a seed-list input for building an agent with discovery service.This is how the generated
api_seed_nodes.rs
file looks like:How Has This Been Tested?
Tested manually by running:
Checklist: