Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log_visibility to canister settings #564

Merged

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Jun 3, 2024

Description

Adds support for the new log_visibility setting in canister settings, both when creating a canister and when updating the settings.

Part of SDK-1543

How Has This Been Tested?

Added tests.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 marked this pull request as ready for review June 3, 2024 09:52
@sesi200 sesi200 requested a review from a team as a code owner June 3, 2024 09:52
@sesi200 sesi200 marked this pull request as draft June 3, 2024 09:57
@sesi200 sesi200 marked this pull request as ready for review June 4, 2024 08:41
@sesi200 sesi200 merged commit 4765eb3 into main Jun 4, 2024
26 checks passed
@sesi200 sesi200 deleted the SDK-1543-add-support-for-log-visibility-in-canister-settings branch June 4, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants