feat: introduce http request retries on tcp failures #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolay-komarevskiy
changed the title
nikolay-komarevskiy
force-pushed
the
BOUN-1114-introduce-request-retries-on-tcp-errors
branch
3 times, most recently
from
bda4fa1
to
6a9eb06
Compare
nikolay-komarevskiy
force-pushed
the
BOUN-1114-introduce-request-retries-on-tcp-errors
branch
from
6a9eb06
to
72f0fff
Compare
nikolay-komarevskiy
force-pushed
the
BOUN-1114-introduce-request-retries-on-tcp-errors
branch
from
0a471aa
to
e2e2674
Compare
nikolay-komarevskiy
force-pushed
the
BOUN-1114-introduce-request-retries-on-tcp-errors
branch
from
e2e2674
to
e536138
Compare
adamspofford-dfinity
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RouteProvider which is used to dynamically retrieve routing URLs for HTTP calls, can potentially return unhealthy URLs. This will be especially acute once API Boundary Node decentralization feature is released, as node providers will be the ones responsible for API nodes maintenance.
If an HTTP request fails on a URL with a network-related error (e.g., host unreachable, connection timeout, connection refused), then this request can be safely retried by using an alternative routing URL, generated by the
RouteProvider. This retrying policy aims at improving user experience.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: