Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: bump candid #494

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Nov 17, 2023

Description

Bump Candid to 0.10. Downstream libraries need to bump Candid to 0.10 as well.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@chenyan-dfinity chenyan-dfinity requested a review from a team as a code owner November 17, 2023 05:27
Cargo.toml Outdated
@@ -10,7 +10,7 @@ members = [
]

[workspace.package]
version = "0.30.2"
version = "0.30.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to make a release just for this, do we?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a release, so that we can bump the downstream candid version.

Copy link
Contributor

@adamspofford-dfinity adamspofford-dfinity Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is a breaking change since candid v0.9 types are no longer accepted by API functions, so it cannot be a point release as you have marked it. I think it would be better to leave off the release for now, and then we can decide later whether a full version just containing the candid bump is necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, sounds good.

Copy link

@frederikrothenberger frederikrothenberger Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I'd like to have a release of the agent in order to upgrade the ic repo to candid 0.10 so that then we can make use of that in Internet Identity.

@chenyan-dfinity chenyan-dfinity changed the title chore: bump candid chore (breaking change): bump candid Nov 17, 2023
@adamspofford-dfinity adamspofford-dfinity changed the title chore (breaking change): bump candid chore!: bump candid Nov 17, 2023
@adamspofford-dfinity adamspofford-dfinity merged commit b7ae339 into dfinity:main Nov 17, 2023
24 of 26 checks passed
adamspofford-dfinity added a commit that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants