-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: bump candid #494
chore!: bump candid #494
Conversation
Cargo.toml
Outdated
@@ -10,7 +10,7 @@ members = [ | |||
] | |||
|
|||
[workspace.package] | |||
version = "0.30.2" | |||
version = "0.30.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to make a release just for this, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have a release, so that we can bump the downstream candid version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it is a breaking change since candid v0.9 types are no longer accepted by API functions, so it cannot be a point release as you have marked it. I think it would be better to leave off the release for now, and then we can decide later whether a full version just containing the candid bump is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I'd like to have a release of the agent in order to upgrade the ic
repo to candid 0.10
so that then we can make use of that in Internet Identity.
This reverts commit b7ae339.
Description
Bump Candid to 0.10. Downstream libraries need to bump Candid to 0.10 as well.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: