Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove fields in expected status endpoint response #485

Merged
merged 2 commits into from
Nov 2, 2023
Merged

feat: remove fields in expected status endpoint response #485

merged 2 commits into from
Nov 2, 2023

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Nov 2, 2023

This PR removes non-optional ic_api_version field (whose value is not meaningfully populated by the replica) and optional impl_source and impl_revision fields (that are not populated by the replica) from the expected /api/v2/status endpoint response.

Here's the corresponding specification MR.

@mraszyk mraszyk requested a review from a team as a code owner November 2, 2023 08:23
@lwshang lwshang merged commit 7ca38f5 into dfinity:main Nov 2, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwshang lwshang lwshang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mraszyk @lwshang