chore: make Envelope struct public #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesi200
approved these changes
Oct 31, 2023
sesi200
reviewed
Oct 31, 2023
ic-agent/src/agent/mod.rs
Outdated
| @@ -12,7 +12,7 @@ pub use agent_error::AgentError; | |||
| pub use builder::AgentBuilder; | |||
| #[doc(inline)] | |||
| pub use ic_transport_types::{ | |||
| signed, EnvelopeContent, RejectCode, RejectResponse, ReplyResponse, RequestStatusResponse, | |||
| signed, Envelope, EnvelopeContent, RejectCode, RejectResponse, ReplyResponse, RequestStatusResponse, | |||
There was a problem hiding this comment.
Suggested change
| signed, Envelope, EnvelopeContent, RejectCode, RejectResponse, ReplyResponse, RequestStatusResponse, | |
| signed, Envelope, EnvelopeContent, RejectCode, RejectResponse, ReplyResponse, | |
| RequestStatusResponse, |
rustfmt complains about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the IC WebSocket Gateway we need the
Envelopestruct to be public also outside theic-agentcrate as the gateway needs to deserialize messages coming from clients and containing a serialized envelope.How Has This Been Tested?
Only made
Envelopestruct public.