Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewer issue where fps is not used correctly #34

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

tylerlum
Copy link
Contributor

The rendering is not working correctly for the hand_robot_viewer. Thus, following the position_retargeting example, the hand + robot example only shows the final state, not the movement of the objects + hands.

python visualize_hand_object.py --dexycb-dir=/juno/u/tylerlum/Downloads/dex_ycb_dataset/  --robots allegro shadow svh

This is because the wrong value is passed into the for loop, so I fixed it.

I also diffed hand_robot_view.py and hand_view.py, and then made 1 other change to make them more consistent

Current:
current_behavior-ezgif com-video-to-gif-converter

New (after fix)
new_behavior-ezgif com-video-to-gif-converter

@yzqin yzqin merged commit ebb0d58 into dexsuite:main Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants