Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ex5 shai #31

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Ex5 shai #31

wants to merge 9 commits into from

Conversation

shikam
Copy link
Collaborator

@shikam shikam commented Nov 24, 2020

No description provided.

noamgu
noamgu reviewed Nov 30, 2020
View reviewed changes
ex2-shai/bootstrap.sh Outdated Show resolved Hide resolved
@noamgu noamgu self-requested a review November 30, 2020 17:59
noamgu
noamgu requested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@noamgu noamgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shikam nicely done.
Pay attention to hard-coded values & fix the conflict you have with ex2-shai/bootstrap.sh

@shikam shikam requested a review from noamgu December 6, 2020 20:19
@noamgu
Copy link
Contributor

noamgu commented Dec 9, 2020

@shikam you still have a conflict :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamgu noamgu Awaiting requested review from noamgu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shikam @noamgu