Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail Travis build if tests fail #9

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fail Travis build if tests fail #9

wants to merge 1 commit into from

Commits on Oct 12, 2018

  1. fail Travis build if tests fail 

    Currently, due to a bug in Travis-CI, the build won't fail
unless the last command in the script directive fails.

This means that if the lint or tests or coverage fail, the
Travis CI build itself won't fail, in turn giving the false
sense that everything is OK and the PR can be merged.

In order to work around this Travis CI limitation we need
to explicitly ask for the shell to exit with an error
immediately if a command exits with a non-zero status.
(set -e)
    @fuzzmz
    fuzzmz committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    e225e63 View commit details
    Browse the repository at this point in the history