Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HPA template API v2 #55

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

iredko-procore
Copy link
Contributor

@iredko-procore iredko-procore commented May 29, 2024

What this PR does / why we need it:

Current HPA implementation doesn't work and fails with the following error:

W0529 19:27:49.287601  108306 warnings.go:70] unknown field "spec.metrics[1].resource.targetAverageUtilization"
Error: UPGRADE FAILED: failed to create resource: HorizontalPodAutoscaler.autoscaling "cti-opencti-worker" is invalid: [spec.metrics[0].resource.target.type: Required value: must specify a metric target type, spec.metrics[0].resource.target.type: Invalid value: "": must be either Utilization, Value, or AverageValue, spec.metrics[0].resource.target.averageUtilization: Required value: must set either a target raw value or a target utilization, spec.metrics[1].resource.target.type: Required value: must specify a metric target type, spec.metrics[1].resource.target.type: Invalid value: "": must be either Utilization, Value, or AverageValue, spec.metrics[1].resource.target.averageUtilization: Required value: must set either a target raw value or a target utilization]

This PR updates workers HPA accordingly to the Kubernetes official docs.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart version bumped
  • Title of the PR starts with chart name

@ialejandro ialejandro self-assigned this May 29, 2024
@ialejandro ialejandro added the bug Something isn't working label May 29, 2024
@ialejandro
Copy link
Member

ialejandro commented May 30, 2024

Thanks a lot! I added on server too.

@ialejandro ialejandro changed the title Patch 1 Fix HPA template API v2 May 30, 2024
@ialejandro ialejandro merged commit d30dfaa into devops-ia:main May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants