-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(languages): use github language names and add new icons #2270
base: develop
Are you sure you want to change the base?
feat(languages): use github language names and add new icons #2270
Conversation
f65dd52
to
011bf7c
Compare
@ReenigneArcher all icons should have an original version, that includes graphql. So that's not intended Edit: The graphql icons should have been named "graphql-original" and "graphql-original-wordmark", and had aliases to "plain" and "plain-wordmark" respectively. |
bc73c6f
to
2b6372c
Compare
This PR is ready for review. |
6f71aa6
to
a0c3b85
Compare
I rebased this again. Regarding the recent I'd like to request a review as I do not want to rebase this repeatedly. I understand it's a really big PR, so please let me know if there's anything I can do to help the process. |
@ReenigneArcher I sadly don't have much time to review this for some time. A few things though:
Sorry about the late reply on this, but I hope this was useful info for you. Don't hesitate to reach out if you need anything, whether it be advice, help or you have any questions |
For point 1, it had to be rebased because there were conflicts. Maybe breaking out the json file into multiple files would be helpful in these cases... Actually the icons in separated folders would be as well. Like an A-Z parent directory. Regarding point 2, do you think that can be improved anytime soon? I don't have time to create 149 PRs, probably no one does, lol. |
Regarding point 2 (again)... It looks like these are areas of interest?
Would you accept a PR allowing this to run over all the changed or new icons? |
Bump |
@ReenigneArcher hi, sorry about the very late response. I have very little time to work on open-source at the moment, but if you made such a PR it would be on the top of my list of things to review. That is true for all workflow/automation related PRs. Anything that makes things easier or faster for reviewers has a high priority now that so few reviewers are active. Also, let me know if you'd consider joining us as a reviewer/maintainer :) |
@Snailedlt Sounds good! I have a good amount of experience with GitHub workflows and actions so I will definitely take a look and see how this can be improved!
I can try to help out when I have down time in my other projects (mainly https://github.com/LizardByte/Sunshine) or waiting for CI to finish, but I don't have a ton of time. I feel like these reviews should not be overly complex though since generally it's not actual code and just icons/json... probably wait to add me until this PR gets merged though, as at that point I will have a better understanding of the requirements and anything I might have missing in this PR. This is a little off topic, but I also have a few suggestions that could make things easier for contributors.
|
Thanks @ReenigneArcher! Regarding your suggestions:
|
a0c3b85
to
5cbc4bd
Compare
I opened #2295 to address multi submissions/edits. |
Double check these details before you open a PR
Features
This PR adds language icons and alias that match the naming GitHub uses in the GitHub API. GitHub uses "linguist" for the languages API. Their list of languages can be found here: https://github.com/github-linguist/linguist/blob/master/lib/linguist/languages.yml
The advantage of this is it makes it possible to use icons directly, without creating a custom mapping.
This PR closes NONE
Notes
I understand that typically new icons are probably submitted one per PR; however since this is somewhat of a new feature (names to match github API), I'd really rather avoid 230 PRs.
The colors for new icons were selected using a color picker. If there was a more prominent color, I selected that, otherwise it may be a random color in some cases (where an icon may have many colors).
I have a question on "graphql". There is no "original" icon, and no alias to it. Is that correct? Edit: I updated the graphql icons based on the comment below.